fix(ui): store evolving code messages under short key for downstream consumers#1373
Open
JasonOA888 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(ui): store evolving code messages under short key for downstream consumers#1373JasonOA888 wants to merge 1 commit intomicrosoft:mainfrom
JasonOA888 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…consumers Messages tagged with 'evolving code' were stored under the full msg.tag key (e.g. 'development.evoving code') but downstream code reads from state.msgs[round]['evolving code']. This caused the UI to always show an empty evolving code list. Fixes microsoft#1021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1021
The
get_msgs_untilfunction stores messages understate.msgs[lround][msg.tag], wheremsg.tagis the full tag string (e.g."development.evoving code"). However, downstream consumers read fromstate.msgs[round]["evolving code"](lines 474, 476, 700), which never gets populated.This fix explicitly appends evolving code messages under the short
"evolving code"key so the UI can display them correctly.Changes:
"evolving code" in tagsbranch ofget_msgs_until, also append tostate.msgs[lround]["evolving code"]Testing:
📚 Documentation preview 📚: https://RDAgent--1373.org.readthedocs.build/en/1373/