Implement LWG-4314: Missing move in mdspan layout mapping::operator()#6244
Open
JMazurkiewicz wants to merge 3 commits intomicrosoft:mainfrom
Open
Implement LWG-4314: Missing move in mdspan layout mapping::operator()#6244JMazurkiewicz wants to merge 3 commits intomicrosoft:mainfrom
JMazurkiewicz wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Member
|
Thanks, I've updated #3807 as you suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements changes to [mdspan.layout.left.obs], [mdspan.layout.right.obs], and [mdspan.layout.stride.obs]. Other changes cannot be addressed here, because:
std::forwardin_Mdspan_checked_index_cast:STL/stl/inc/mdspan
Lines 1225 to 1237 in da06be8
std::forwardin other occurrences ofindex-castshould not be observable by users.I think we should close #6209 and mention LWG-4314 in #3807.