Skip to content

Persist Authentication header for authority-scope URL when repo has submodules #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sphanley wants to merge 2 commits into
base: master
Choose a base branch
from
+21 −0
Open

Persist Authentication header for authority-scope URL when repo has submodules #5511

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14f946b
Persist authority URL auth header when repo has submodules
sphanley Mar 25, 2026
ca45128
Merge branch 'master' into feature/persist-submodule-header
sphanley Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/Agent.Plugins/GitSourceProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,6 +1228,27 @@ public async Task GetSourceAsync(
throw new InvalidOperationException($"Git config failed with exit code: {exitCode_config}");
}
}

// persist credentials for authorityUrl so submodules at the same root domain can authenticate
if (checkoutSubmodules)
{
string authorityUrl = repositoryUrl.AbsoluteUri.Replace(repositoryUrl.PathAndQuery, string.Empty);
string submoduleConfigKey = $"http.{authorityUrl}.extraheader";
configModifications[submoduleConfigKey] = configValue.Trim('\"');

if (gitUseSecureParameterPassing)
{
await SetAuthTokenInGitConfig(executionContext, gitCommandManager, targetPath, submoduleConfigKey, configValue.Trim('\"'));
}
else
{
int exitCode_config = await gitCommandManager.GitConfig(executionContext, targetPath, submoduleConfigKey, configValue);
if (exitCode_config != 0)
{
throw new InvalidOperationException($"Git config failed with exit code: {exitCode_config}");
}
}
}
}

if (!gitSupportAuthHeader && !exposeCred)
Expand Down