Skip to content

Fix BinaryTargetManager line endings #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
David Quiceno (v-davidquiceno-ascendion) wants to merge 1 commit into
base: fix/large-debug-str
Choose a base branch
from
Open

Fix BinaryTargetManager line endings #1218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/BinSkim.Sdk/BinaryTargetManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ internal static class BinaryTargetManager
// However, for now this will do.
public static IBinary GetBinaryFromFile(Uri uri,
string symbolPath = null,
string localSymbolDirectories = null,
bool tracePdbLoad = false,
bool forceComprehensiveParsing = false,
ulong? dwarfStringSectionFileReadThreshold = null)
string localSymbolDirectories = null,
bool tracePdbLoad = false,
bool forceComprehensiveParsing = false,
ulong? dwarfStringSectionFileReadThreshold = null)
{
// TryLoadBinary avoids the separate CanLoadBinary sniff,
// eliminating a redundant file open for every PE file.
Expand All @@ -28,10 +28,10 @@ public static IBinary GetBinaryFromFile(Uri uri,

if (ElfBinary.CanLoadBinary(uri))
{
return new ElfBinary(uri,
localSymbolDirectories,
forceComprehensiveParsing,
dwarfStringSectionFileReadThreshold);
return new ElfBinary(uri,
localSymbolDirectories,
forceComprehensiveParsing,
dwarfStringSectionFileReadThreshold);
}
else if (MachOBinary.CanLoadBinary(uri))
{
Expand Down