Open
Conversation
eladiw
force-pushed
the
feature/add_github_support
branch
from
713de09 to
3790a07
Compare
erikschlegel
approved these changes
Jun 2, 2021
Contributor
erikschlegel
left a comment
erikschlegel
left a comment
There was a problem hiding this comment.
This is great work @eladiw. Thanks for putting in the time for this PR. It's great to see us offer support for a new orchestrator provider.
| terraform state list | grep random_password | xargs -L 1 terraform taint | ||
| terraform plan | ||
|
|
||
| # Note: this command might fail due to the rapid create/delete on Azure resources. If it fails, re-running it |
Contributor
There was a problem hiding this comment.
Curious on why this would fail?
Author
There was a problem hiding this comment.
copied as is from the Gitlab readme file. I think this can be removed from both versions. wdyt?
| * A shell environment, preferrably bash | ||
| * A Github personal access token. Instructions for generating one can be found [here](https://docs.github.com/en/github/authenticating-to-github/keeping-your-account-and-data-secure/creating-a-personal-access-token). The token will need the `workflow` permission. | ||
| * An Azure subscription | ||
|
|
Contributor
There was a problem hiding this comment.
AFAICT, the terraform template that's being run is also creating an AAD App and SP. If that's the case then you may want to mention the developer will need owner level permissions on the az sub.
Author
|
@erikschlegel updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Github actions support.
Based on the Gitlab version.
A matching Bedrock PR which builds on this PR : microsoft/bedrock#1457
Note:
In the Gitlab version secrets and variables were used. For Github there, variables are not an option, so every value is stored as a secret.
All Submissions:
What is the current behavior?
Github actions is not supported
Issue Number: N/A
What is the new behavior?
Adding Github acctions support
Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information