Conversation
9a4b705 to
c7d9fcf
Compare
…cks fixture Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
c7d9fcf to
8965f6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds the
lifecycle-callbackstest fixture to@microsoft/fast-htmland generates itsindex.htmlusing@microsoft/fast-build, consistent with the other fixtures (attribute,binding,event,ref,slotted,when,repeat,repeat-event,children).The
lifecycle-callbacksfixture covers FAST element lifecycle callbacks (connectedCallback,disconnectedCallback,attributeChangedCallback) and deferred hydration via theneeds-hydrationanddefer-hydrationattributes. It verifies that SSR correctly renders initial state for elements using these lifecycle patterns, and that FAST properly hydrates and activates bindings after connection.🎫 Issues
No open issues directly addressed.
📑 Test Plan
npm run build:fixturesinpackages/fast-htmlruns cleanly and regenerateslifecycle-callbacks/index.htmlwith correct shadow DOM content rendered from root state.✅ Checklist
General
$ npm run change