Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… attr
Rebase onto main (includes all previous fixtures up to lifecycle-callbacks).
Resolved build-fixtures.js conflict by appending 'dot-syntax' to the
full fixture list.
Remove object="{{object}}" from entry.html — root JSON state is passed
implicitly by @microsoft/fast-build. The 'object' key in state.json
is a non-primitive; the SSR strips it from the HTML attr anyway and
uses it only for template state resolution.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
janechu
force-pushed
the
users/janechu/update-fixture-to-use-fast-build-dot-syntax
branch
from
d33e73e to
380d1e9
Compare
janechu
deleted the
users/janechu/update-fixture-to-use-fast-build-dot-syntax
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds the
dot-syntaxtest fixture to@microsoft/fast-htmland generates itsindex.htmlusing@microsoft/fast-build, consistent with the other fixtures (attribute,binding,event,ref,slotted,when,repeat,repeat-event,children,host-bindings,lifecycle-callbacks).The
dot-syntaxfixture covers deep object property access in FAST template bindings (e.g.{{object.b}},{{object.a.b2.c}}). It verifies that@microsoft/fast-buildcorrectly resolves nested dot-notation expressions from the root JSON state during SSR, and that FAST hydration properly reconnects those bindings for reactive updates.The entry element in
entry.htmlhas no binding attributes — root JSON state is passed implicitly by@microsoft/fast-build. Theobjectkey instate.jsonis a non-primitive; the SSR uses it for template resolution without emitting it as an HTML attribute.🎫 Issues
No open issues directly addressed.
📑 Test Plan
npm run build:fixturesinpackages/fast-htmlruns cleanly and regeneratesdot-syntax/index.html— shadow DOM correctly renders nested object values (bar,FOO, etc.) from root state with noobjectattribute on the entry element.✅ Checklist
General
$ npm run change