Skip to content

chore(fast-html): use @microsoft/fast-build to build performance-metrics fixture#7389

Merged
janechu merged 1 commit intomainfrom
users/janechu/update-fixture-to-use-fast-build-performance-metrics
Apr 8, 2026
Merged

chore(fast-html): use @microsoft/fast-build to build performance-metrics fixture#7389
janechu merged 1 commit intomainfrom
users/janechu/update-fixture-to-use-fast-build-performance-metrics

Conversation

@janechu
Copy link
Copy Markdown
Collaborator

@janechu janechu commented Apr 4, 2026

Pull Request

📖 Description

Adds the performance-metrics test fixture to @microsoft/fast-html and generates its index.html using @microsoft/fast-build, consistent with the other fixtures.

The performance-metrics fixture covers deferred hydration with configurable delays (defer-delay). It renders 14 fast-card elements across three delay groups (0ms, 150ms, 300ms) and verifies that @microsoft/fast-build correctly pre-renders their shadow DOM content.

Redundant {{binding}} attrs (willHydrate, didHydrate, hydrationDuration) have been removed from entry elements — their property names match the root state.json keys so they are passed implicitly. Static attrs (needs-hydration, defer-hydration, defer-delay, displayDelay) are preserved. The duplicate changefile from the original two commits has also been removed.

🎫 Issues

No open issues directly addressed.

📑 Test Plan

  • npm run build:fixtures in packages/fast-html runs cleanly and regenerates performance-metrics/index.html with all 14 fast-card elements correctly rendered from root state.
  • All other fixture outputs are unchanged.

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu force-pushed the users/janechu/update-fixture-to-use-fast-build-performance-metrics branch 2 times, most recently from 3831e9d to a48cff9 Compare April 8, 2026 18:42
Rebase onto main (includes all previous fixtures up to nested-elements).
Resolved build-fixtures.js conflict by appending 'performance-metrics'.

Squash two commits into one and remove the extra changefile.
Remove redundant {{binding}} attrs (willHydrate, didHydrate, hydrationDuration)
from entry elements — property names match root state.json keys so they are
passed implicitly. Static attrs (needs-hydration, defer-hydration, defer-delay,
displayDelay) are preserved.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@janechu janechu force-pushed the users/janechu/update-fixture-to-use-fast-build-performance-metrics branch from a48cff9 to a7f6959 Compare April 8, 2026 18:47
@janechu janechu marked this pull request as ready for review April 8, 2026 18:50
@janechu janechu merged commit a5fb102 into main Apr 8, 2026
14 checks passed
@janechu janechu deleted the users/janechu/update-fixture-to-use-fast-build-performance-metrics branch April 8, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant