Conversation
3831e9d to
a48cff9
Compare
Rebase onto main (includes all previous fixtures up to nested-elements).
Resolved build-fixtures.js conflict by appending 'performance-metrics'.
Squash two commits into one and remove the extra changefile.
Remove redundant {{binding}} attrs (willHydrate, didHydrate, hydrationDuration)
from entry elements — property names match root state.json keys so they are
passed implicitly. Static attrs (needs-hydration, defer-hydration, defer-delay,
displayDelay) are preserved.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
a48cff9 to
a7f6959
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds the
performance-metricstest fixture to@microsoft/fast-htmland generates itsindex.htmlusing@microsoft/fast-build, consistent with the other fixtures.The
performance-metricsfixture covers deferred hydration with configurable delays (defer-delay). It renders 14fast-cardelements across three delay groups (0ms, 150ms, 300ms) and verifies that@microsoft/fast-buildcorrectly pre-renders their shadow DOM content.Redundant
{{binding}}attrs (willHydrate,didHydrate,hydrationDuration) have been removed from entry elements — their property names match the rootstate.jsonkeys so they are passed implicitly. Static attrs (needs-hydration,defer-hydration,defer-delay,displayDelay) are preserved. The duplicate changefile from the original two commits has also been removed.🎫 Issues
No open issues directly addressed.
📑 Test Plan
npm run build:fixturesinpackages/fast-htmlruns cleanly and regeneratesperformance-metrics/index.htmlwith all 14fast-cardelements correctly rendered from root state.✅ Checklist
General
$ npm run change