Update Status Colors to latest Fluent 2 guidance#2231
Conversation
|
Should the dark elevated colors from the screenshot be added as well to the alias tokens you're updating? They might not have been defined when we initially did the fluent 2 update so I can do a pass later on with the new design tokens for the remaining ones. |
|
@laminesm it looks like there's a conflict in FluentTheme+macOS where warningBackground1 was changed recently. Thinking about it further I'm not sure if this PR should actually include changes to FluentTheme+macOS since only the iOS toolkit was used as a reference and I'm not entirely sure if iOS and macOS need to match for status colors or not. Wondering if you have thoughts on this as I can either revert the changes to FluentTheme+macOS so that we don't touch that in this PR since the original goal was to update the iOS colors. Or we can move forward with matching the status colors between iOS and macOS like we currently have in this PR. Any thoughts would be appreciated. |
@philworthington Yep I think we can go ahead and update for iOS now and I'll spin up a task for updating mac colors separately if fluent designers confirm mac and iOS should be aligned. Thanks! |
Per PR review feedback, scope this PR to iOS only. macOS status color updates will be tracked separately pending Fluent design alignment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@laminesm I pushed an update removing the macOS theme changes for this PR. Should be good to merge this one after a reapproval, thanks! |
|
@laminesm looks like we have a failing check. Probably a flaky test however I don't have permissions to re run it, wondering if you can trigger a re run and hopefully it passes next time. |
|
Yep the failures seemed unrelated. Kicked off a new try, thanks. |
|
Thanks @laminesm, looks like we're good to merge. I don't seem to have permissions to merge either so if you could help with that we can finally wrap this one up! |
Platforms Impacted
Description of changes
A recent audit of the Fluent 2 iOS Toolkit which references tokens in Fluent 2 design language shows updated status colors that differ from the current FluentUI implementation.
To access the tokens:
Verification
Danger Toast: Red -> Cranberry colors
Warning Toast: Yellow -> DarkOrange colors
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow