[release-branch.go1.27] Bump go-crypto-winnative to latest - #2468
Open
Quim Muntal (qmuntal) wants to merge 1 commit into
Open
[release-branch.go1.27] Bump go-crypto-winnative to latest#2468Quim Muntal (qmuntal) wants to merge 1 commit into
Quim Muntal (qmuntal) wants to merge 1 commit into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates vendored go-crypto-winnative to commit 418c3f76f8f8.
Changes:
- Bumps module, checksum, and vendor metadata.
- Refreshes Windows CNG code and architecture-specific layouts.
Show a summary per file
| File | Summary |
|---|---|
patches/0001-Vendor-external-dependencies.patch |
Updates the vendored dependency and embedded sources. Nit: remove redundant build tags from _windows_386.go. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Comment on lines
+39905
to
+39908
| +//go:build windows && 386 | ||
| +// +build windows,386 | ||
| + | ||
| +package bcrypt |
Davis Goodin (dagood)
requested changes
Aug 21, 2026
| + github.com/microsoft/go-crypto-darwin v0.0.3-0.20260619075948-e554deeefa9f // indirect | ||
| + github.com/microsoft/go-crypto-openssl v0.5.1-0.20260728092821-b4aef158c3ae // indirect | ||
| + github.com/microsoft/go-crypto-winnative v0.0.0-20260605073512-713d2add0825 // indirect | ||
| + github.com/microsoft/go-crypto-winnative v0.0.0-20260821094543-418c3f76f8f8 // indirect |
There was a problem hiding this comment.
Different from latest in ms-go1.27-support 8030c1795 ?
George Adams (gdams)
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates go-crypto-winnative from 713d2add0825 to 418c3f76f8f8.
Tests: