Bump go-crypto-winnative to latest - #2471
Open
Quim Muntal (qmuntal) wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the vendored dependency github.com/microsoft/go-crypto-winnative from 6c31d8dd0a62 to 418c3f76f8f8 by updating the vendor patch, including corresponding go.mod/go.sum and modules.txt updates.
Changes:
- Bumped
github.com/microsoft/go-crypto-winnativepseudo-version and hashes insrc/go.modandsrc/go.sum(via the vendor patch). - Updated vendored CNG KDF-related code (HKDF/PBKDF2/TLS1PRF) to use GC-visible pointers (
unsafe.Pointer) andruntime.KeepAliveto ensure parameter lifetimes across syscalls. - Updated
src/vendor/modules.txtentry forgo-crypto-winnativeto the new version andgoversion marker.
Show a summary per file
| File | Description |
|---|---|
| patches/0001-Vendor-external-dependencies.patch | Updates the vendor patch to the newer go-crypto-winnative revision, including module metadata and vendored Windows CNG interop changes. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Comment on lines
39126
to
39130
| + var size uint32 | ||
| + err = bcrypt.KeyDerivation(kh, params, out, &size, 0) | ||
| + runtime.KeepAlive(params) | ||
| + if err != nil { | ||
| + return nil, err |
Martijn Verburg (karianna)
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates go-crypto-winnative from 6c31d8dd0a62 to 418c3f76f8f8.
Tests: