freebsd: enable systemcrypto with cgo on all architectures - #2476
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Microsoft Go systemcrypto enablement logic so FreeBSD targets keep systemcrypto enabled by default (like Linux/macOS), while producing an explicit compile-time failure only when building unsupported FreeBSD architectures without cgo. It also restores Windows 386 support in the shared “systemcrypto supported” platform checks and updates the generated crypto documentation accordingly.
Changes:
- Enable
systemcryptofor FreeBSD in shared platform gating, and preserve Windows386in those checks. - Add a FreeBSD-specific
nocgobuild-failure shim (for non-amd64/arm64) and a correspondingcmd/gotest that asserts the expected failure mode/message. - Regenerate/update the CrossPlatformCryptography documentation to reflect FreeBSD support with/without cgo.
Patches are happy!
Show a summary per file
| File | Description |
|---|---|
| patches/0002-Add-crypto-backends.patch | Updates the patch payload to treat FreeBSD as systemcrypto-supported by default, preserve Windows 386 support, and add an explicit FreeBSD nocgo failure path + tests. |
| eng/doc/CrossPlatformCryptography.md | Updates the FreeBSD narrative and cgo support table to reflect systemcrypto enablement behavior. |
| eng/_util/cmd/updatecryptodocs/header.md | Updates the docs generator header so the regenerated documentation matches the new FreeBSD support matrix. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
George Adams (gdams)
force-pushed
the
dev/gadams/freebsd386
branch
2 times, most recently
from
August 24, 2026 14:41
1650ddb to
8d830c2
Compare
Quim Muntal (qmuntal)
approved these changes
Aug 24, 2026
George Adams (gdams)
enabled auto-merge (squash)
August 24, 2026 14:46
Keep systemcrypto enabled for FreeBSD targets and emit an explicit build failure only when an unsupported architecture is built without cgo. Also preserve Windows 386 support in the shared platform checks and update the generated crypto documentation. Closes #2474
George Adams (gdams)
force-pushed
the
dev/gadams/freebsd386
branch
from
August 24, 2026 15:48
8d830c2 to
767251c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep systemcrypto enabled for FreeBSD targets and emit an explicit build failure only when an unsupported architecture is built without cgo. Also preserve Windows 386 support in the shared platform checks and update the generated crypto documentation.
Closes #2474