[release-branch.go1.27] freebsd: enable systemcrypto with cgo on all architectures - #2477
Merged
George Adams (gdams) merged 1 commit intoAug 24, 2026
Conversation
…architectures Keep systemcrypto enabled for all FreeBSD targets and emit an explicit build failure when an unsupported architecture is built without cgo. Leave Windows systemcrypto support unchanged. Backport the FreeBSD portion of #2474.
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
George Adams (gdams)
enabled auto-merge (squash)
August 24, 2026 14:59
Contributor
There was a problem hiding this comment.
Pull request overview
Backports FreeBSD systemcrypto support for Go 1.27.
Changes:
- Enables all FreeBSD architectures with cgo.
- Adds explicit failures and regression coverage for unsupported no-cgo targets.
- Updates cryptography documentation and its generator template.
Show a summary per file
| File | Description |
|---|---|
patches/0002-Add-crypto-backends.patch |
Adds FreeBSD support logic, diagnostics, and tests. |
eng/doc/CrossPlatformCryptography.md |
Updates FreeBSD support documentation. |
eng/_util/cmd/updatecryptodocs/header.md |
Updates the documentation generator template. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (1)
eng/doc/CrossPlatformCryptography.md:34
- This new support statement makes the existing platform-support references in
eng/doc/fips/README.md:122anddocs/go1.27.md:25inaccurate: both still say FreeBSD systemcrypto is limited to amd64/arm64. Please update those companion documents (and any generated/source counterpart) in the same change so users do not get conflicting architecture guidance.
All FreeBSD architectures are supported with cgo enabled; without cgo, only `amd64` and `arm64` are supported.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
Quim Muntal (qmuntal)
approved these changes
Aug 24, 2026
George Adams (gdams)
merged commit Aug 24, 2026
b59cc78
into
microsoft/release-branch.go1.27
57 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the FreeBSD portion of #2474 to Go 1.27.
Validation:
go test internal/systemcryptogo test internal/platform -run '^$'\n-go test cmd/dist -run '^$'\n-go test cmd/go -run '^TestSystemCryptoFreeBSDNoCgo$'\n-go test ./cmd/updatecryptodocs