docs: update hooks.md event name list and count to include sessionEnd and userPromptSubmitted - #2549
Merged
WilliamBerryiii merged 3 commits intoJul 31, 2026
Conversation
… and userPromptSubmitted
rezatnoMsirhC
approved these changes
Jul 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2549 +/- ##
==========================================
- Coverage 82.75% 82.73% -0.03%
==========================================
Files 155 155
Lines 20963 20943 -20
Branches 13 13
==========================================
- Hits 17348 17327 -21
- Misses 3613 3614 +1
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
WilliamBerryiii
approved these changes
Jul 31, 2026
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the "Manifest Schema and Validation" section in
docs/contributing/hooks.mdto accurately reflect the allowed hook event names defined in the JSON schema.The schema (
scripts/linting/schemas/hook-manifest.schema.json) defines ten allowed event names, but the documentation previously stated there were "eight" and missed two in the inline enumeration. This PR updates the count from "eight" to "ten" and addssessionEndanduserPromptSubmittedto the list so the documentation perfectly matches the schema'spropertyNames.enum.Related Issue(s)
Fixes #2498
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
hve-builderand addressed all actionable findings.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md).github/hooks/*/*.json)evals/)Other:
.ps1,.sh,.py)Testing
propertyNames.enumarray inscripts/linting/schemas/hook-manifest.schema.jsonto ensure a 1:1 match.npm run lint:hookslocally to ensure no manifest validation regressions (Passed successfully).Checklist
Required Checks
AI Artifact Contributions
(Not applicable for this documentation-only fix)
Required Local Checks
npm run validate:localnpm run validate:docsnpm run spell-checknpm run lint:md-linksSecurity Considerations
Additional Notes
This was a simple documentation mismatch introduced in PR #2478 where the schema and compatibility sections were updated, but the introductory enumeration and count were missed. No code or schema changes were required for this fix.