Open
Conversation
baa5d36 to
789f039
Compare
Zakariathr22
approved these changes
Jan 12, 2026
789f039 to
7393778
Compare
Contributor
Author
|
Any advise for the attention points? @Zakariathr22 |
Zakariathr22
left a comment
There was a problem hiding this comment.
@Jay-o-Way
My suggestion is to keep the cleanup you’ve already done and address the other points in separate PRs, as those points require review and alignment with the maintainers.
Contributor
Author
|
Okay I see. So what's the hold on this one? The longer a PR stays open, the more chance of merge conflicts. And I don't like those 🤓 |
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Example for #10951
PR Type
Please check the type of change your PR introduces:
Description
Many changes to MD files. Starting with only the "Specs" folder. (for now)
For example, but not limited:
/en-us/bits (!)csharpand not withcsorc#Motivation and Context
A company as big as Microsoft should have perfect documentation.
How Has This Been Tested?
Extra:
Important
Document-specific points of attention:
in AnimatedVisualPlayer Spec
AnimationOptimizationversusAnimationsCacheModein custom-iresourcemanager-spec
CustomResourceManagerversusResourcein FooterMenuItemTemplate-spec
FooterMenuItemSourceversusFooterMenuItemsSource→ typo?in NavigationViewTemplateSettings-OpenPaneLength
OpenPaneLength="{Binding ... TemplateSettings.OpenPaneWidth}"should beOpenPaneLength