Skip to content

Parameterize PDO::lastInsertId() sequence-name lookup and fix non-ASCII sequence names#1673

Merged
David-Engel merged 3 commits into
devfrom
david/lastid
Jul 17, 2026
Merged

Parameterize PDO::lastInsertId() sequence-name lookup and fix non-ASCII sequence names#1673
David-Engel merged 3 commits into
devfrom
david/lastid

test(pdo): set UTF-8 connection encoding for Unicode sequence-name case

c0a15b8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 16, 2026 in 1s

85.80% (+0.00%) compared to 5fe2823

View this Pull Request on Codecov

85.80% (+0.00%) compared to 5fe2823

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.80%. Comparing base (5fe2823) to head (c0a15b8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1673   +/-   ##
=======================================
  Coverage   85.80%   85.80%           
=======================================
  Files          23       23           
  Lines        7247     7251    +4     
=======================================
+ Hits         6218     6222    +4     
  Misses       1029     1029           
Files with missing lines Coverage Δ
source/pdo_sqlsrv/pdo_dbh.cpp 91.36% <100.00%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.