fix: Preserve GLiNER config fields through Pydantic validation#2007
Open
yuriihavrylko wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: Preserve GLiNER config fields through Pydantic validation#2007yuriihavrylko wants to merge 1 commit intomicrosoft:mainfrom
yuriihavrylko wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Add GLiNERRecognizerConfig to the YAML recognizer config model and register it in
CONFIG_MODEL_MAP, so that model_name and other GLiNER-specific fields (flat_ner,threshold,multi_label,map_location,load_onnx_model,onnx_model_file,entity_mapping) are preserved through Pydantic validation when loading recognizer configuration from YAML.Root cause: When parsing a GLiNERRecognizer entry from YAML, parse_recognizers looked up "GLiNERRecognizer" in
CONFIG_MODEL_MAPand found nothing, falling back to PredefinedRecognizerConfig. Since that class has no model_name field and Pydantic's default is to ignore extra fields,model_name(and all other GLiNER params) were silently dropped. The recognizer would then always load the hardcoded default model (urchade/gliner_multi_pii-v1) regardless of what was specified in config. HuggingFaceNerRecognizer already had this handled correctly via HuggingFaceRecognizerConfig.Issue reference
Fixes #XX
Checklist