[pbi-fixer] Add fix_whole_number_format: set #,0 format on integer measures - #1201
Open
KornAlexander wants to merge 3 commits into
Open
[pbi-fixer] Add fix_whole_number_format: set #,0 format on integer measures#1201KornAlexander wants to merge 3 commits into
KornAlexander wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new semantic-model fixer, fix_whole_number_format(), intended to standardize formatting for whole-number measures in the sempy_labs.semantic_model surface area as part of the PBI Fixer contribution tracked in #1185.
Changes:
- Adds
fix_whole_number_format()in a new standalone module undersemantic_model. - Scans measures in a semantic model and assigns
#,0when the fixer decides a measure is an unformatted whole number. - Re-exports the new fixer from
sempy_labs.semantic_model.__init__.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/sempy_labs/semantic_model/_Fix_WholeNumberFormat.py |
Introduces the new fixer implementation that opens the TOM model, scans measures, applies formatting, and reports results. |
src/sempy_labs/semantic_model/__init__.py |
Re-exports the new fixer so it is available from the semantic_model package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…redundant SaveChanges
Author
|
Thanks copilot-pull-request-reviewer for the review. Addressed all three findings in 127d2b2:
|
1 similar comment
Author
|
Thanks copilot-pull-request-reviewer for the review. Addressed all three findings in 127d2b2:
|
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a sempy_labs fixer
fix_whole_number_format()that set #,0 format on integer measures.Adds one source file (
src/sempy_labs/semantic_model/_Fix_WholeNumberFormat.py) plus one re-export line in the matching__init__.py. No other files touched, no shared helpers, no dependency on any other PR.Part of the PBI Fixer contribution. Tracking issue: #1185