[pbi-fixer] Add add_calculated_calendar: add a comprehensive CalcCalendar calculated table if no calendar exists - #1211
Open
KornAlexander wants to merge 3 commits into
Conversation
…ted table if no calendar exists
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new sempy_labs.semantic_model utility/fixer function, add_calculated_calendar(), intended to ensure a semantic model backing a given report has a comprehensive Time-category calendar table (creating CalcCalendar when none exists).
Changes:
- Introduces
add_calculated_calendar()which detects existing Time-category tables and otherwise creates aCalcCalendarcalculated table with columns, sort-by settings, hierarchies, and optional/auto relationships. - Adds a semantic-model refresh call to calculate the newly created table.
- Re-exports
add_calculated_calendarfromsempy_labs.semantic_model.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/sempy_labs/semantic_model/_Add_CalculatedTable_Calendar.py |
Implements add_calculated_calendar() including DAX definition, metadata setup, relationship auto-detection, and refresh. |
src/sempy_labs/semantic_model/__init__.py |
Re-exports add_calculated_calendar via __all__. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
May 5, 2026 15:03
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a sempy_labs fixer
add_calculated_calendar()that add a comprehensive CalcCalendar calculated table if no calendar exists.Adds one source file (
src/sempy_labs/semantic_model/_Add_CalculatedTable_Calendar.py) plus one re-export line in the matching__init__.py. No other files touched, no shared helpers, no dependency on any other PR.Part of the PBI Fixer contribution. Tracking issue: #1185