[pbi-fixer] Add add_measure_table: add an empty Measure calculated table to centralize measures - #1212
Open
KornAlexander wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new semantic model “fixer” utility to ensure a report’s backing semantic model contains a dedicated calculated table (named "Measure") intended as a centralized container for measures.
Changes:
- Introduces
add_measure_table()to detect existing “measure” tables and (optionally) create a placeholder calculated table when missing. - Re-exports
add_measure_tablefromsempy_labs.semantic_modelvia__init__.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/sempy_labs/semantic_model/_Add_CalculatedTable_MeasureTable.py |
New fixer that scans for existing measure tables and creates/hides a placeholder calculated table when absent. |
src/sempy_labs/semantic_model/__init__.py |
Re-exports add_measure_table from the semantic_model package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| None | ||
| """ | ||
|
|
||
| workspace_name, workspace_id = resolve_workspace_name_and_id(workspace) |
| # --------------------------------------------------------------------------- | ||
| _MT_TABLE_NAME = "Measure" | ||
|
|
||
| # A single-row, zero-column calculated table — the lightest possible placeholder. |
… lint, init imports)
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a sempy_labs fixer
add_measure_table()that add an empty Measure calculated table to centralize measures.Adds one source file (
src/sempy_labs/semantic_model/_Add_CalculatedTable_MeasureTable.py) plus one re-export line in the matching__init__.py. No other files touched, no shared helpers, no dependency on any other PR.Part of the PBI Fixer contribution. Tracking issue: #1185