Add DAX query timing capture helper - #1246
Open
edwardpcharles wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new public utility to run a DAX query under an SSAS trace and return a one-row timing summary (Total/SE/FE), with accompanying unit tests and package export.
Changes:
- Introduce
capture_dax_query_timings()to execute a tagged DAX query, capture trace events, and compute timing breakdown. - Add unit tests covering a normal trace and an empty-trace fallback path.
- Export the new function from
sempy_labspublic API.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_capture_dax_query_timings.py | Adds tests for the new timing/trace summarization behavior. |
| src/sempy_labs/_dax.py | Implements capture_dax_query_timings() and required imports. |
| src/sempy_labs/init.py | Re-exports capture_dax_query_timings as part of the public API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new public sempy_labs API, capture_dax_query_timings, that runs a DAX query under SSAS trace and returns a single summary DataFrame with total, storage engine, and formula engine timings. Also wires the function into package exports and adds targeted unit tests.