Skip to content

Enhancement - Support AMDGPU_TARGETS in ROCm CMake builds #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polarG merged 4 commits into from
May 23, 2026
+28 −4
Merged

Enhancement - Support AMDGPU_TARGETS in ROCm CMake builds #793

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0ac11f
Support AMDGPU_TARGETS in ROCm CMake builds
Mar 25, 2026
0652f38
Address PR review comments for AMDGPU_TARGETS handling
Apr 27, 2026
3800dbd
Address review feedback for AMDGPU_TARGETS handling
May 3, 2026
da9c47f
Merge branch 'main' into dev/hongtaozhang/fix-rocm-without-gpu-arch-set
polarG May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions superbench/benchmarks/micro_benchmarks/rocm_common.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,25 @@ else()
set(HIP_PATH $ENV{HIP_PATH})
endif()

# Turn off CMAKE_HIP_ARCHITECTURES Feature if cmake version is 3.21+
if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.21.0)
set(CMAKE_HIP_ARCHITECTURES OFF)
# Set HIP architectures from AMDGPU_TARGETS environment variable if available.
# AMDGPU_TARGETS should be a space-separated list of GPU architectures,
# e.g. "gfx908 gfx90a gfx942".
# Both the CMake variable AMDGPU_TARGETS and CMAKE_HIP_ARCHITECTURES must be set:
# - AMDGPU_TARGETS is read by ROCm's hip-config-amd.cmake to set --offload-arch flags
# - CMAKE_HIP_ARCHITECTURES is the native CMake variable for HIP (requires >= 3.21)
Comment thread
polarG marked this conversation as resolved.
Outdated
if(DEFINED ENV{AMDGPU_TARGETS})
string(REPLACE " " ";" HIP_ARCH_LIST "$ENV{AMDGPU_TARGETS}")
Comment thread
polarG marked this conversation as resolved.
Outdated
set(AMDGPU_TARGETS ${HIP_ARCH_LIST} CACHE STRING "AMD GPU targets to compile for")
Comment thread
polarG marked this conversation as resolved.
Outdated
if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.21.0)
set(CMAKE_HIP_ARCHITECTURES ${HIP_ARCH_LIST})
endif()
message(STATUS "Using AMDGPU_TARGETS from environment: ${HIP_ARCH_LIST}")
Comment thread
polarG marked this conversation as resolved.
Outdated
else()
if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.21.0)
set(CMAKE_HIP_ARCHITECTURES OFF)
endif()
message(STATUS "AMDGPU_TARGETS not set, relying on hipcc auto-detection")
endif()
message(STATUS "CMAKE HIP ARCHITECTURES: ${CMAKE_HIP_ARCHITECTURES}")

if(EXISTS ${HIP_PATH})
# Search for hip in common locations
Expand Down
Loading