Draft
Conversation
Contributor
Author
|
Member
|
AI review (shortened by me since miyanyan already identified the ports that need to be updated or delisted): SummaryThis PR updates ASIO from version 1.32.0 to 1.36.0, which introduces breaking API changes that cause compilation failures in 10 unique ports across multiple platforms. 🔴 Root Cause AnalysisASIO 1.36.0 Breaking API ChangesASIO version 1.36.0 introduced significant API changes that are incompatible with code written for ASIO 1.32.0: 1. Removal of
|
| Category | Count | Details |
|---|---|---|
| io_service API removal | 5 ports | opendnp3, tcp-pubsub, vcpkg-ci-rest-rpc, and others |
| Timer method signature changes | 2 ports | opendnp3 (via exe4cpp), others |
| Executor API changes | 2 ports | hpx, pulsar-client-cpp |
| General ASIO incompatibility | 3 ports | sese, nrf-ble-driver, others |
⚠️ Known / Expected Failures in Baseline
The following ports were already failing in the baseline (before this PR), so their failure is not a regression caused by this update. However, the failures may now be due to different root causes:
| Port | Triplet(s) | Baseline Entry | Status |
|---|---|---|---|
| hwloc | arm-neon-android, arm64-android, x64-android | fail |
Known failure |
| nrf-ble-driver | arm-neon-android, arm64-android, arm64-linux, x64-android | fail |
Known failure |
| openmpi | arm-neon-android, arm64-android, x64-android | fail |
Known failure |
| spscqueue | arm-neon-android, arm64-android, x64-android | fail |
Known failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.Fixes #49576