Feat: Support for vscode settings expansions like ${workspaceFolder}#1790
Draft
Attempt3035 wants to merge 1 commit intomicrosoft:developfrom
Draft
Feat: Support for vscode settings expansions like ${workspaceFolder}#1790Attempt3035 wants to merge 1 commit intomicrosoft:developfrom
Attempt3035 wants to merge 1 commit intomicrosoft:developfrom
Conversation
Attempt3035
requested review from
chagong,
testforstephen and
wenytang-ms
as code owners
Author
|
@microsoft-github-policy-service agree |
chagong
reviewed
Apr 1, 2026
| import * as fse from "fs-extra"; | ||
| import * as path from "path"; | ||
| import { findDefaultRuntimeFromSettings, getMajorVersion, listJdks } from "./jdkUtils"; | ||
| const vscodeVariables = require('vscode-variables'); |
chagong
reviewed
Apr 1, 2026
| "dependencies": { | ||
| "await-lock": "^2.2.2", | ||
| "jdk-utils": "^0.4.4", | ||
| "vscode-variables": "^1.0.1", |
Contributor
There was a problem hiding this comment.
Is it a package officially support by microsoft?
Author
There was a problem hiding this comment.
I don't believe so, source: https://github.com/DominicVonk/vscode-variables
I can implement the replacement logic manually if preferred, it's straightforward for simple cases like ${workspaceFolder} but vscode-variables does a good job at providing full functionality especially supporting multi root to end users
Contributor
There was a problem hiding this comment.
It would be nice if you can implement "resolve variables" in our repo. I think it only needs to resolve paths, no need to include commands & config stuff. Resolve commands might have some security concern.
Contributor
|
Also fix the lint errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows setting vscode settings with variable substitutions such as:
Also supports other substitutions available in vscode-variables package
PR currently open on vscode-java for same feature