feat: add client telemetry support - #585
Merged
sre-ci-robot merged 13 commits intoAug 25, 2026
Merged
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f69630f982
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
yhmo
reviewed
Aug 24, 2026
yhmo
reviewed
Aug 24, 2026
yhmo
reviewed
Aug 24, 2026
yhmo
reviewed
Aug 24, 2026
yhmo
reviewed
Aug 24, 2026
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Sampling kept a counter modulo 10000 and recorded an operation while the remainder was under rate*10000, so the sampled operations formed one contiguous run per cycle. A cycle is ten thousand operations while a heartbeat window is tens or hundreds, so every window came out wholly sampled or wholly dropped: at 3 QPS a rate of 0.25 gave fourteen minutes of full metrics followed by forty-one reporting nothing from a client that never stopped working. The long-run ratio was right; the ratio inside a window, which is the only unit the telemetry API reports, never was. Accumulate the rate instead and sample on the operation that carries the accumulator across a whole unit: 0.25 samples every fourth operation, and any stretch of operations holds the configured ratio. A rate too small to represent now still samples rarely rather than never -- the old threshold truncated anything below 1e-4 to zero and then sampled nothing, so a configured rate silently meant "off". Matches the Go client, milvus-io/milvus#52615. Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
The heartbeat interval is also the metrics window: each heartbeat carries the operations since the last one, and the coordinator answers a telemetry query from the window before the newest, so a caller reads data between one and two intervals old. At the previous default of 30 seconds that is up to a minute behind, which reads as a stalled client rather than as a lagging view. Ten seconds puts the worst case at twenty. The cost is the coordinator heartbeat rate, which scales with the number of connected clients rather than with traffic; a deployment with enough clients for that to matter can raise the interval, per client or fleet-wide, with a persistent push_config. Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
xiaofan-luan
force-pushed
the
feat/client-telemetry
branch
from
August 24, 2026 09:42
722e13c to
8eec85c
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #585 +/- ##
===========================================
+ Coverage 53.47% 87.28% +33.80%
===========================================
Files 52 379 +327
Lines 4432 15796 +11364
Branches 0 1715 +1715
===========================================
+ Hits 2370 13787 +11417
+ Misses 2062 2009 -53
🚀 New features to boost your workflow:
|
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
yhmo
reviewed
Aug 24, 2026
yhmo
reviewed
Aug 24, 2026
yhmo
reviewed
Aug 24, 2026
yhmo
reviewed
Aug 24, 2026
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Collaborator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan, yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related work
Verification
Compatibility note
ConnectParam gains telemetry configuration state. Consumers should rebuild against this SDK revision rather than mixing binaries compiled against the previous object layout.