Skip to content

enhance: [cp3.0]rewrite storage.MergeSort as a proper k-way merge - #52429

Merged
sre-ci-robot merged 1 commit into
milvus-io:3.0from
bigsheeper:cp-3.0-51998
Aug 14, 2026
Merged

enhance: [cp3.0]rewrite storage.MergeSort as a proper k-way merge#52429
sre-ci-robot merged 1 commit into
milvus-io:3.0from
bigsheeper:cp-3.0-51998

Conversation

@bigsheeper

@bigsheeper bigsheeper commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Cherry-pick from master

pr: #51998
issue: #51981

Summary

Cherry-picked from master PR #51998 (merged)

Verification

  • File count matches original PR
  • Code changes verified against master PR diff (line-level comparison)
  • No conflict markers
  • make static-check (skipped by cherry-pick workflow)

🤖 Generated with Claude Code

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Aug 11, 2026
@mergify mergify Bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 11, 2026
@sre-ci-robot sre-ci-robot added the do-not-merge/need-milestone generate by v2-label-manager label Aug 11, 2026
@sre-ci-robot

sre-ci-robot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #51998 merged to master

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@bigsheeper bigsheeper added this to the 3.0.2 milestone Aug 11, 2026
@sre-ci-robot

sre-ci-robot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: ci-v2 system is enabled for this PR (3.0 branch).

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests)
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e tests)
  • /ci-rerun-e2e-amd-gray // for ci-v2/e2e-amd-gray (TC pool shadow; non-gating)
  • /ci-rerun-e2e-dist-wp // for ci-v2/e2e-dist-wp (Tencent distributed woodpecker-service boundary)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests)
  • /ci-rerun-gosdk-std // for ci-v2/go-sdk-std (Go SDK E2E, standalone)
  • /ci-rerun-gosdk-dist-wp // for ci-v2/go-sdk-dist-wp (distributed + Woodpecker service)

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot

sre-ci-robot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

✅ CI Loop Results b514702

Stage Result Duration Tests
✅ Build SUCCESS 15.8min -
✅ Code-Check SUCCESS 11.5min -
✅ UT-Integration SUCCESS 25.2min -
✅ UT-GO SUCCESS 23.2min -
✅ UT-CPP-Cov SUCCESS 57.3min 8502 total, 8502 passed, 0 failed

Total: 81min | Pipeline | Artifacts

Overall Coverage: 52.3%
Diff Coverage: CPP 86.4% (821 hit, 129 miss, 950 measurable lines, 1283 unmeasured) | Go 0.0% (0 hit, 162 miss, 162 measurable lines, 135 unmeasured)
Diff Coverage HTML: view changed lines
Total Patch Coverage: 73.8% (821/1112 measurable lines, 1418 unmeasured)

@bigsheeper @claude
enhance: [cp3.0]rewrite storage.MergeSort as a proper k-way merge
7890e24 
Cherry-pick from master PR milvus-io#51998

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot removed the do-not-merge/need-milestone generate by v2-label-manager label Aug 13, 2026
@sre-ci-robot

sre-ci-robot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #51998 merged to master

Use /refresh-label to update related check and label manually

@sre-ci-robot

sre-ci-robot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

✅ CI Loop Results 7890e24

Stage Result Duration Tests
✅ Build SUCCESS 11.8min -
✅ Code-Check SUCCESS 7.8min -
✅ UT-Integration SUCCESS 24.7min -
✅ UT-GO SUCCESS 22.5min -
✅ UT-CPP-Cov SUCCESS 44.0min 8548 total, 8548 passed, 0 failed

Total: 73min | Pipeline | Artifacts

Overall Coverage: 52.4%
Diff Coverage: CPP 87.4% (521 hit, 75 miss, 596 measurable lines, 886 unmeasured) | Go 0.0% (0 hit, 162 miss, 162 measurable lines, 135 unmeasured)
Diff Coverage HTML: view changed lines
Total Patch Coverage: 68.7% (521/758 measurable lines, 1021 unmeasured)

@bigsheeper

bigsheeper commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/ci-rerun-e2e-amd

@mergify mergify Bot added the ci-passed label Aug 13, 2026
@sre-ci-robot

sre-ci-robot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #51998 merged to master

Use /refresh-label to update related check and label manually

czs007
czs007 approved these changes Aug 14, 2026
View reviewed changes

@czs007 czs007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot

sre-ci-robot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot

sre-ci-robot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #51998 merged to master

Use /refresh-label to update related check and label manually

@sre-ci-robot
sre-ci-robot merged commit afcf7e8 into milvus-io:3.0 Aug 14, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czs007 czs007 czs007 approved these changes
@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333
@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@czs007 czs007

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.

Projects

None yet

Milestone

3.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@bigsheeper @sre-ci-robot @czs007