Skip to content

fix: check_invalid_binary_vector should not raise on non-sized values #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lokeshramchand-ctrl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: check_invalid_binary_vector should not raise on non-sized values #3769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6df0953
fix: check_invalid_binary_vector should not raise on non-sized values
lokeshramchand-ctrl Aug 23, 2026
8900f65
fix: guard first binary-vector element before computing dim
lokeshramchand-ctrl Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pymilvus/client/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,15 +159,18 @@ def check_invalid_binary_vector(entities: List) -> bool:
if not isinstance(entity["values"], list) or len(entity["values"]) == 0:
return False

if not isinstance(entity["values"][0], bytes):
return False

dim = len(entity["values"][0]) * 8
if dim == 0:
return False

for values in entity["values"]:
if len(values) * 8 != dim:
return False
if not isinstance(values, bytes):
return False
if len(values) * 8 != dim:
Comment thread
lokeshramchand-ctrl marked this conversation as resolved.
return False
return True


Expand Down
12 changes: 12 additions & 0 deletions tests/unit/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,18 @@ def test_empty_values(self):
entities = [{"type": DataType.BINARY_VECTOR, "values": []}]
assert utils.check_invalid_binary_vector(entities) is False

def test_non_sized_value(self):
entities = [{"type": DataType.BINARY_VECTOR, "values": [b"\x00\x01", None]}]
assert utils.check_invalid_binary_vector(entities) is False
Comment thread
lokeshramchand-ctrl marked this conversation as resolved.

def test_non_sized_first_value(self):
entities = [{"type": DataType.BINARY_VECTOR, "values": [None, b"\x00\x01"]}]
assert utils.check_invalid_binary_vector(entities) is False

def test_all_non_sized_values(self):
entities = [{"type": DataType.BINARY_VECTOR, "values": [1, 2]}]
assert utils.check_invalid_binary_vector(entities) is False


class TestSparseParseSingleRow:
def test_basic_parsing(self):
Expand Down