Skip to content

fix: return False for non-sized binary vector values #3777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krudo-taco wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: return False for non-sized binary vector values #3777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pymilvus/client/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,16 @@ def check_invalid_binary_vector(entities: List) -> bool:
if not isinstance(entity["values"], list) or len(entity["values"]) == 0:
return False

dim = len(entity["values"][0]) * 8
first = entity["values"][0]
if not isinstance(first, bytes):
return False

dim = len(first) * 8
if dim == 0:
return False

for values in entity["values"]:
if len(values) * 8 != dim:
return False
if not isinstance(values, bytes):
if not isinstance(values, bytes) or len(values) * 8 != dim:
return False
return True

Expand Down
10 changes: 10 additions & 0 deletions tests/unit/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,16 @@ def test_non_bytes_values(self):
entities = [{"type": DataType.BINARY_VECTOR, "values": [[0, 1], [2, 3]]}]
assert utils.check_invalid_binary_vector(entities) is False

def test_non_sized_values(self):
entities = [{"type": DataType.BINARY_VECTOR, "values": [None]}]
assert utils.check_invalid_binary_vector(entities) is False

entities = [{"type": DataType.BINARY_VECTOR, "values": [1, 2]}]
assert utils.check_invalid_binary_vector(entities) is False

entities = [{"type": DataType.BINARY_VECTOR, "values": [b"\x00\x01", None]}]
assert utils.check_invalid_binary_vector(entities) is False

def test_empty_values(self):
entities = [{"type": DataType.BINARY_VECTOR, "values": []}]
assert utils.check_invalid_binary_vector(entities) is False
Expand Down