Skip to content

fix: preserve struct params and accept inherited nullability - #3789

Open
SpadeA-Tang wants to merge 1 commit into
milvus-io:masterfrom
SpadeA-Tang:tiny-fixes
Open

fix: preserve struct params and accept inherited nullability#3789
SpadeA-Tang wants to merge 1 commit into
milvus-io:masterfrom
SpadeA-Tang:tiny-fixes

Conversation

@SpadeA-Tang

@SpadeA-Tang SpadeA-Tang commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@SpadeA-Tang
fix: preserve struct params and accept inherited nullability
e96086a 
  - Preserve parent type params when describing struct fields.
  - Avoid double JSON encoding of sub-field string parameters.
  - Allow nullable sub-fields when the parent struct is nullable.

Signed-off-by: SpadeA <tangchenjie1210@gmail.com>
@sre-ci-robot

sre-ci-robot commented Sep 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SpadeA-Tang
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify Bot added the dco-passed label Sep 8, 2026
@mergify

mergify Bot commented Sep 8, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@codecov

codecov Bot commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.23%. Comparing base (a4b3b38) to head (e96086a).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3789   +/-   ##
=======================================
  Coverage   94.22%   94.23%           
=======================================
  Files          77       77           
  Lines       16204    16205    +1     
=======================================
+ Hits        15268    15270    +2     
+ Misses        936      935    -1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify Bot added the ci-passed label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tedxu tedxu Awaiting requested review from tedxu
@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees

No one assigned

Labels

ci-passed dco-passed size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SpadeA-Tang @sre-ci-robot