fix: QueryIterator checkpoint file bugs on empty/short cp files and f… - #3793
Open
vickyandvicky wants to merge 1 commit into
Open
fix: QueryIterator checkpoint file bugs on empty/short cp files and f…#3793vickyandvicky wants to merge 1 commit into
vickyandvicky wants to merge 1 commit into
Conversation
…ailed saves Two related correctness bugs in QueryIterator's checkpoint handling: 1. __init_cp_file_handler() decided resume-vs-fresh based only on whether the cp file exists, not whether it has usable content. A cp file left behind by a process interrupted before writing anything (0 lines) or interrupted right after the first save (1 line, ts only, no cursor) was incorrectly rejected with ParamError instead of being resumed/started fresh. 2. next() advanced the in-memory cursor before confirming the checkpoint write succeeded. A failed save left the cursor pointing past a batch that was never actually returned to the caller -- silently dropping that batch on any retry. Fixes milvus-io#3744 Signed-off-by: Rayudu Vikramaditya <laxion528@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vickyandvicky The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @vickyandvicky! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ailed saves
Two related correctness bugs in QueryIterator's checkpoint handling:
__init_cp_file_handler() decided resume-vs-fresh based only on whether the cp file exists, not whether it has usable content. A cp file left behind by a process interrupted before writing anything (0 lines) or interrupted right after the first save (1 line, ts only, no cursor) was incorrectly rejected with ParamError instead of being resumed/started fresh.
next() advanced the in-memory cursor before confirming the checkpoint write succeeded. A failed save left the cursor pointing past a batch that was never actually returned to the caller -- silently dropping that batch on any retry.
Fixes #3744