build(deps): bump milvus-proto to ae7fea6a - #3797
Merged
sre-ci-robot merged 1 commit intoSep 15, 2026
Merged
sre-ci-robot merged 1 commit into
sre-ci-robot merged 1 commit into
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3797 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 77 77
Lines 16204 16204
=======================================
Hits 15268 15268
Misses 936 936 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Upgrade the complete proto baseline, including compaction lifecycle metadata from milvus-io/milvus-proto#668, and regenerate Python bindings with grpcio-tools 1.66.2 so milvus-io#3791 can contain only SDK implementation and tests after rebasing. Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han
force-pushed
the
codex/proto-baseline-before-compaction
branch
from
September 15, 2026 03:32
9bc8b9f to
07475a5
Compare
Contributor
|
need to cp to 3.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrPresent-Han, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
Sep 15, 2026
) (#3799) ## What changed - Bump the PyMilvus 3.0 `milvus-proto` submodule from `0d1eefd` to `9e4f0eb`. - Regenerate the Python protobuf bindings from merged `milvus-io/milvus-proto#669`. ## Why This establishes the 3.0 protocol baseline required by the compaction lifecycle observability backport without mixing generated protocol changes into the feature PR. ## Verification - `make check_proto_product` - Related PyMilvus unit tests pr: #3797 Signed-off-by: MrPresent-Han <chun.han@gmail.com> Co-authored-by: MrPresent-Han <chun.han@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #3790
related pr: #3791
Scope
Upgrade PyMilvus's complete protocol baseline separately from the SDK API implementation in #3791.
0fb0d5bcf2e2ff4dff30683e5aa0f8991a20d011directly toae7fea6ab2f4e958f2feef0f0edb9a0d23fa7e0c.grpcio-tools==1.66.2.Relationship to #3791
This PR now contains the full protocol bump, including compaction metadata; it no longer stops at the pre-compaction revision.
Merge this PR first, then rebase #3791 onto master so that #3791 contains only six SDK implementation files and five unit-test files.
The entire
pymilvus/grpc_gentree, including the proto submodule pointer, matches #3791 exactly, so all ten protocol-related entries disappear from that PR's diff after the rebase, reducing 21 changed files to 11 without changing SDK behavior.Validation
git diff --checkpasses.tests/unitrun on the fullae7fea6abaseline: 4,718 passed, 3 skipped, 1 failed in 54.42 seconds.tests/unit/orm/test_types.py::TestInferDtypeBydata::test_numpy_like_with_dtype_returns_float_vector(FLOATinferred versus expectedFLOAT_VECTOR), which was independently reproduced on unchangedtrunk/masterata4b3b38bbd8baa4c1047dccb7647a3bc47defcdbin the same environment during the baseline preparation; no unrelated SDK or test fix is included.