Skip to content

build(deps): bump milvus-proto to ae7fea6a - #3797

Merged
sre-ci-robot merged 1 commit into
milvus-io:masterfrom
MrPresent-Han:codex/proto-baseline-before-compaction
Sep 15, 2026
Merged

sre-ci-robot merged 1 commit into
milvus-io:masterfrom
MrPresent-Han:codex/proto-baseline-before-compaction

Conversation

@MrPresent-Han

@MrPresent-Han MrPresent-Han commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

issue: #3790
related pr: #3791

Scope

Upgrade PyMilvus's complete protocol baseline separately from the SDK API implementation in #3791.

  • Advance the proto submodule from 0fb0d5bcf2e2ff4dff30683e5aa0f8991a20d011 directly to ae7fea6ab2f4e958f2feef0f0edb9a0d23fa7e0c.
  • Include the merged compaction protocol changes from feat: expose compaction lifecycle observability metadata milvus-proto#668: public task-state/type enums, retained segment lifecycle filtering and lineage, collection task selectors, failure reasons, and complete task targets.
  • Include the other upstream protocol updates between these commits for UUID/nested arrays, RLS, snapshot export, import metadata, and shard routing.
  • Regenerate the Python messages, typing stubs, and service bindings with the repository generator and pinned grpcio-tools==1.66.2.
  • Change only the proto submodule and its nine generated files; no handwritten SDK logic, tests, generators, or dependency constraints are changed.

Relationship to #3791

This PR now contains the full protocol bump, including compaction metadata; it no longer stops at the pre-compaction revision.

Merge this PR first, then rebase #3791 onto master so that #3791 contains only six SDK implementation files and five unit-test files.

The entire pymilvus/grpc_gen tree, including the proto submodule pointer, matches #3791 exactly, so all ten protocol-related entries disappear from that PR's diff after the rebase, reducing 21 changed files to 11 without changing SDK behavior.

Validation

  • The complete protocol tree matches enhance: add compaction lifecycle observability APIs #3791 byte-for-byte.
  • No handwritten code or tests differ from master in this PR.
  • Repeating generation produces no diff, and git diff --check passes.
  • Complete tests/unit run on the full ae7fea6a baseline: 4,718 passed, 3 skipped, 1 failed in 54.42 seconds.
  • The only failure is tests/unit/orm/test_types.py::TestInferDtypeBydata::test_numpy_like_with_dtype_returns_float_vector (FLOAT inferred versus expected FLOAT_VECTOR), which was independently reproduced on unchanged trunk/master at a4b3b38bbd8baa4c1047dccb7647a3bc47defcdb in the same environment during the baseline preparation; no unrelated SDK or test fix is included.
  • This is protocol-generation and unit-test verification, not Milvus server E2E verification.
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=. \
  python -m pytest -q --disable-warnings --tb=short --show-capture=no \
  -o log_cli=false -p no:cacheprovider -p pytest_asyncio.plugin \
  -p pytest_timeout --timeout=45 tests/unit

@mergify

mergify Bot commented Sep 15, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.22%. Comparing base (a4b3b38) to head (07475a5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3797   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files          77       77           
  Lines       16204    16204           
=======================================
  Hits        15268    15268           
  Misses        936      936           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify Bot added the ci-passed label Sep 15, 2026
Upgrade the complete proto baseline, including compaction lifecycle metadata from milvus-io/milvus-proto#668, and regenerate Python bindings with grpcio-tools 1.66.2 so milvus-io#3791 can contain only SDK implementation and tests after rebasing.

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
@MrPresent-Han
MrPresent-Han force-pushed the codex/proto-baseline-before-compaction branch from 9bc8b9f to 07475a5 Compare September 15, 2026 03:32
@MrPresent-Han MrPresent-Han changed the title build(deps): sync proto baseline before compaction metadata build(deps): bump milvus-proto to ae7fea6a Sep 15, 2026
@mergify mergify Bot added ci-passed and removed ci-passed labels Sep 15, 2026
@XuanYang-cn

Copy link
Copy Markdown
Contributor

need to cp to 3.0
/lgtm
/approve

@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrPresent-Han, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
sre-ci-robot merged commit 8bd86b7 into milvus-io:master Sep 15, 2026
14 checks passed
sre-ci-robot pushed a commit that referenced this pull request Sep 15, 2026
) (#3799)

## What changed

- Bump the PyMilvus 3.0 `milvus-proto` submodule from `0d1eefd` to
`9e4f0eb`.
- Regenerate the Python protobuf bindings from merged
`milvus-io/milvus-proto#669`.

## Why

This establishes the 3.0 protocol baseline required by the compaction
lifecycle observability backport without mixing generated protocol
changes into the feature PR.

## Verification

- `make check_proto_product`
- Related PyMilvus unit tests

pr: #3797

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants