Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions css/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,11 @@ a {
border-radius: 0.25em;
}
.dark-theme .has-thin-scrollbar::-webkit-scrollbar-track {
background-color: rgba(255, 255, 255, 0.25);
background-color: rgba(0, 0, 0, 0.3);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look very good against a dark-gray background; let's leave the background as-is:

Image

}
.dark-theme .has-thin-scrollbar::-webkit-scrollbar-thumb {
background-color: rgba(255, 255, 255, 0.6);
background-color: rgba(255, 255, 255, 0.3);
}
.dark-theme .has-thin-scrollbar::-webkit-scrollbar-thumb:hover {
background-color: rgba(255, 255, 255, 0.5);
}
17 changes: 15 additions & 2 deletions css/tabBar.css
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ body.linux #menu-button {
.tab-item {
flex: 1;
min-width: 125px;
transition: 0.2s transform;
transition: flex 0.3s cubic-bezier(0.4, 0, 0.2, 1), min-width 0.3s cubic-bezier(0.4, 0, 0.2, 1), background-color 0.2s, transform 0.2s;
line-height: 36px;
height: 36px;
overflow: hidden;
Expand All @@ -113,7 +113,13 @@ body.linux #menu-button {
padding-right: 0.5rem;
}
.tab-item.active {
min-width: 168px;
flex: 1.1;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the flex rule here? Let's apply the growing/shrinking effect only when there are many tabs open.

min-width: 220px;
}
/* When 5 or more tabs are open, make active tab grow more */
.tab-item:first-child:nth-last-child(n+5).active,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use .compact-tabs .tab-item.active. That class is set from JS and also considers the window width to determine whether the tabs will be small.

.tab-item:first-child:nth-last-child(n+5) ~ .tab-item.active {
flex: 1.6;
}
.tab-item.gu-mirror {
top: var(--control-space-top) !important;
Expand Down Expand Up @@ -161,6 +167,13 @@ body.linux #menu-button {

.tab-item:not(.active):hover {
background-color: rgba(0, 0, 0, 0.03);
flex: 1.05;
min-width: 156px;
}
/* When 5 or more tabs are open, make hover grow more */
.tab-item:first-child:nth-last-child(n+5):not(.active):hover,
.tab-item:first-child:nth-last-child(n+5) ~ .tab-item:not(.active):hover {
flex: 1.25;
}
.dark-theme .tab-item:not(.active):hover {
background-color: rgba(255, 255, 255, 0.1);
Expand Down
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@
<input type="search" id="task-search-input"/>
</div>
</div>
<div id="task-area"></div>
<div id="task-area" class="has-thin-scrollbar"></div>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task list has plenty of space for a native scrollbar, so I think we should continue doing that.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything will be ready today

<button id="add-task">
<i class="i carbon:new-tab"></i>
<span></span>
Expand Down