-
-
Notifications
You must be signed in to change notification settings - Fork 842
feat: improve UI animations and tab behavior #2679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -100,7 +100,7 @@ body.linux #menu-button { | |
| .tab-item { | ||
| flex: 1; | ||
| min-width: 125px; | ||
| transition: 0.2s transform; | ||
| transition: flex 0.3s cubic-bezier(0.4, 0, 0.2, 1), min-width 0.3s cubic-bezier(0.4, 0, 0.2, 1), background-color 0.2s, transform 0.2s; | ||
| line-height: 36px; | ||
| height: 36px; | ||
| overflow: hidden; | ||
|
|
@@ -113,7 +113,13 @@ body.linux #menu-button { | |
| padding-right: 0.5rem; | ||
| } | ||
| .tab-item.active { | ||
| min-width: 168px; | ||
| flex: 1.1; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you remove the flex rule here? Let's apply the growing/shrinking effect only when there are many tabs open. |
||
| min-width: 220px; | ||
| } | ||
| /* When 5 or more tabs are open, make active tab grow more */ | ||
| .tab-item:first-child:nth-last-child(n+5).active, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can use |
||
| .tab-item:first-child:nth-last-child(n+5) ~ .tab-item.active { | ||
| flex: 1.6; | ||
| } | ||
| .tab-item.gu-mirror { | ||
| top: var(--control-space-top) !important; | ||
|
|
@@ -161,6 +167,13 @@ body.linux #menu-button { | |
|
|
||
| .tab-item:not(.active):hover { | ||
| background-color: rgba(0, 0, 0, 0.03); | ||
| flex: 1.05; | ||
| min-width: 156px; | ||
| } | ||
| /* When 5 or more tabs are open, make hover grow more */ | ||
| .tab-item:first-child:nth-last-child(n+5):not(.active):hover, | ||
| .tab-item:first-child:nth-last-child(n+5) ~ .tab-item:not(.active):hover { | ||
| flex: 1.25; | ||
| } | ||
| .dark-theme .tab-item:not(.active):hover { | ||
| background-color: rgba(255, 255, 255, 0.1); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -241,7 +241,7 @@ | |
| <input type="search" id="task-search-input"/> | ||
| </div> | ||
| </div> | ||
| <div id="task-area"></div> | ||
| <div id="task-area" class="has-thin-scrollbar"></div> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The task list has plenty of space for a native scrollbar, so I think we should continue doing that.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Everything will be ready today |
||
| <button id="add-task"> | ||
| <i class="i carbon:new-tab"></i> | ||
| <span></span> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look very good against a dark-gray background; let's leave the background as-is: