[Fix] DDP init with device id - #2136
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
==========================================
+ Coverage 97.01% 97.06% +0.04%
==========================================
Files 169 169
Lines 10000 10000
==========================================
+ Hits 9701 9706 +5
+ Misses 299 294 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves distributed training reliability and device management for all detection, recognition, layout, and table training scripts. The main changes ensure that PyTorch's distributed process group is correctly initialized with device information and that CUDA-aware barriers are used for synchronization, which helps prevent deadlocks and device mismatch errors.
Distributed Training Initialization:
train.pyscripts (detection,recognition,layout,table) now initialize the process group with thedevice_idargument, ensuring each process is explicitly associated with the correct CUDA device. [1] [2] [3] [4]Barrier Synchronization Improvements:
barrier_downloadcontext manager in allddp_utils.pymodules (detection,recognition,layout,table) now uses a helper function to calldist.barrierwithdevice_idswhen using the NCCL backend and CUDA, ensuring correct device synchronization and avoiding potential deadlocks.These changes collectively improve robustness and compatibility for multi-GPU distributed training across all relevant modules.