add min-len and max-len parameters to mc share upload#5184
Open
devnewton wants to merge 3 commits into
Open
Conversation
Contributor
|
expected curl upload to fail as upload size if 6B and min-len was set as 2048 |
…ax-len parameters
Author
|
I forgot to check the error returned by SetContentLengthRange. It ensures than min-len is smaller than max-len. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
harshavardhana
approved these changes
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Allow to specify content length range with
mc share uploadcommand.Motivation and Context
This is usefull to share upload link with length restriction.
This feature is already present in minio java client.
How to test this PR?
Create a test bucket on play server and share an upload using --max-len parameter then upload a file larger than expected:
Types of changes
Checklist: