Skip to content

test_create_and_remove_desktop: Revert original focus#44

Open
stdedos wants to merge 1 commit into
mirober:masterfrom
stdedos:test/fix-test_create_and_remove_desktop-focus
Open

test_create_and_remove_desktop: Revert original focus#44
stdedos wants to merge 1 commit into
mirober:masterfrom
stdedos:test/fix-test_create_and_remove_desktop-focus

Conversation

@stdedos

@stdedos stdedos commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

When using current_desktop.go(), in 18363, the focus is not restored to the original window

Signed-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com

When using `current_desktop.go()`, in 18363, the focus is not restored to the original window

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
@@ -95,6 +95,7 @@ def test_create_and_remove_desktop():

time.sleep(1) # Got to wait for the animation before we can return

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think that could be replaced with

https://github.com/mrob95/pyvda/blob/11762ff22a2799833dbf9116edc00501d39d4cc6/pyvda/com_defns.py#L207

?

And/or overload the "future method" with time.sleep(1) on unsupporting platforms?

(However, I wouldn't know how to code that 😅)

@mirober

mirober commented Mar 2, 2024

Copy link
Copy Markdown
Owner

Is this a problem for normal usage? e.g. When you change desktops using go, does the focus get left behind? I remember this used to happen sometimes but seems to have been fixed on later Windows versions

@stdedos

stdedos commented Mar 4, 2024

Copy link
Copy Markdown
Contributor Author

No, that's not it. Switching to a new desktop, "naturally" has no window to focus.
Then, "for some reason", when coming back, there is no restored focus.

If I just switch back-and-forth from desktops that have windows, it works.

If I switch to an existing desktop that has no windows, it still works:

Python 3.11.8 (tags/v3.11.8:db85d51, Feb  6 2024, 22:03:32) [MSC v.1937 64 bit (AMD64)]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.22.2 -- An enhanced Interactive Python. Type '?' for help.

In [1]: from pyvda import (
   ...:     AppView,
   ...:     VirtualDesktop,
   ...:     get_virtual_desktops,
   ...:     get_apps_by_z_order,
   ...: )
   ...: import pprint
   ...: from win32gui import GetWindowText, GetForegroundWindow
   ...: import time
   ...:

In [2]:
   ...: pprint.pprint([GetWindowText(a.hwnd) for a in get_apps_by_z_order()])
   ...: print("Now focused on: ", end="")
   ...: print(GetWindowText(GetForegroundWindow()))
   ...: VirtualDesktop(3).go()
   ...: time.sleep(1)
   ...: pprint.pprint([GetWindowText(a.hwnd) for a in get_apps_by_z_order()])
   ...: print("Now focused on: ", end="")
   ...: print(GetWindowText(GetForegroundWindow()))
   ...: VirtualDesktop(1).go()
   ...: time.sleep(1)
   ...: pprint.pprint([GetWindowText(a.hwnd) for a in get_apps_by_z_order()])
   ...: print("Now focused on: ", end="")
   ...: print(GetWindowText(GetForegroundWindow()))
['IPython: E:pyvda/pyvda',
 'Extensions - Refined GitHub - Google Chrome']
Now focused on: IPython: E:pyvda/pyvda
[]
Now focused on:
['IPython: E:pyvda/pyvda',
 'Extensions - Refined GitHub - Google Chrome']
Now focused on: IPython: E:pyvda/pyvda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants