Refactor Twig Compiler Pass#154
Open
dTatham wants to merge 1 commit into
Open
Conversation
|
SF4 compatibility exist and waiting for merge in #153 |
Author
|
Okay, I’ll wait for the merge and rebase if necessary |
Member
|
@dTatham At least some of this has been covered by other PRs - could you rebase so we can check whatever's left? Thanks. |
Switched to relying on configuration to pick the template Signed-off-by: Daniel Zauner <daniel@zauner.email>
84df120 to
639d53d
Compare
Author
|
Alrighty, here's what's left after the rebase:
I'm not sure if DependencyInjection/Compiler/FormPhpTemplateCompilerPass.php needs an update as well as I'm not familiar with Symfony PHP theming. |
Nek-
pushed a commit
to Nek-/phone-number-bundle
that referenced
this pull request
Mar 26, 2025
…-3-9-3 Prepare version 3.9.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've added some basic support for SF4 and refactored the Twig template compiler pass to allow for a configuration parameter rather than automatically picking a template (needed it to squish the country widget into an input-group)
Still open:
This is my first PR, so if there's anything missing please let me know :)