Add support for bootstrap_4(_horizontal)_layout.html.twig#181
Add support for bootstrap_4(_horizontal)_layout.html.twig#181mathiasstocker wants to merge 1 commit into
Conversation
|
Just looking very briefly I’m not sure what this code is originally for - did you work it out? |
|
Symfony has built in form themes for Bootstrap 3 and newly added Bootstrap 4: The phone number bundle worked when Bootstrap 3 form theme was activated but does not work with Bootstrap 4. This pull request fixes this issue. |
|
Also see #179 |
|
+1, need this fix |
|
+1 |
|
Until this is fixed you can use my fork: @rh389 What about my pull request, is something not ok? Maybe you should disable tests on hhvm in Travis CI, seems there is no code coverage driver configured |
|
any update about this PR? |
|
Can we expect a solution for bootstrap 4 forms ? Is is still not working... |
|
Hi, why about one year later this pull request is still not accepted ? |
|
@rh389 Hi, can you accept up this PR please ? |
|
If you want, you can redirect your PR to this repo : https://github.com/odolbeau/phone-number-bundle |
remove $ so gitclip works, fix bundle version
No description provided.