Skip to content

Add support for bootstrap_4(_horizontal)_layout.html.twig#181

Open
mathiasstocker wants to merge 1 commit into
misd-service-development:masterfrom
mathiasstocker:bootstrap4
Open

Add support for bootstrap_4(_horizontal)_layout.html.twig#181
mathiasstocker wants to merge 1 commit into
misd-service-development:masterfrom
mathiasstocker:bootstrap4

Conversation

@mathiasstocker

Copy link
Copy Markdown

No description provided.

@robhogan

Copy link
Copy Markdown
Member

Just looking very briefly I’m not sure what this code is originally for - did you work it out?

@mathiasstocker

Copy link
Copy Markdown
Author

Symfony has built in form themes for Bootstrap 3 and newly added Bootstrap 4:
https://symfony.com/doc/current/form/form_customization.html#what-are-form-themes

The phone number bundle worked when Bootstrap 3 form theme was activated but does not work with Bootstrap 4.

This pull request fixes this issue.

@mathiasstocker

Copy link
Copy Markdown
Author

Also see #179

@claire1604

Copy link
Copy Markdown

+1, need this fix

@ruscon

ruscon commented Aug 25, 2018

Copy link
Copy Markdown

+1

@mathiasstocker

Copy link
Copy Markdown
Author

Until this is fixed you can use my fork:
https://github.com/mathiasstocker/phone-number-bundle

@rh389 What about my pull request, is something not ok? Maybe you should disable tests on hhvm in Travis CI, seems there is no code coverage driver configured

@kariae

kariae commented Nov 4, 2018

Copy link
Copy Markdown

any update about this PR?

@effetb

effetb commented Jan 11, 2019

Copy link
Copy Markdown

Can we expect a solution for bootstrap 4 forms ? Is is still not working...

@effetb

effetb commented Apr 10, 2019

Copy link
Copy Markdown

Hi, why about one year later this pull request is still not accepted ?

@florianlemenach

Copy link
Copy Markdown

@rh389 Hi, can you accept up this PR please ?

@maxhelias

Copy link
Copy Markdown

If you want, you can redirect your PR to this repo : https://github.com/odolbeau/phone-number-bundle
We would be happy to merge this :)

Nek- pushed a commit to Nek-/phone-number-bundle that referenced this pull request Mar 26, 2025
remove $ so gitclip works, fix bundle version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants