Skip to content

Possibility to override the label in country widget #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mablae wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

Possibility to override the label in country widget #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Form/Type/PhoneNumberType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,14 @@ public function buildForm(FormBuilderInterface $builder, array $options)
if (false === isset($countries[$region])) {
continue;
}

if (null !== $options['country_widget_label'] && is_callable($options['country_widget_label'])) {
$countryChoices[$options['country_widget_label']($countries, $name, $region)] = $region;
} else {
$countryChoices[sprintf('%s (+%s)', $name, $countries[$region])] = $region;
}

@mablae mablae May 1, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbuh Is a default sprintf() call okay, in order to get rid off the else branch?

@xabbuh xabbuh May 2, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would you place that sprintf() call?


$countryChoices[sprintf('%s (+%s)', $name, $countries[$region])] = $region;
}

$transformerChoices = array_values($countryChoices);

$countryOptions = $numberOptions = array(
Expand Down Expand Up @@ -141,6 +145,7 @@ public function configureOptions(OptionsResolver $resolver)
'by_reference' => false,
'error_bubbling' => false,
'country_choices' => array(),
'country_widget_label' => null,
'preferred_country_choices' => array(),
)
);
Expand Down