Fix shot#persist_enable=false#1896
Draft
bosh wants to merge 3 commits intomissionpinball:devfrom
Draft
Conversation
bosh
force-pushed
the
test_shot_persist_enable
branch
from
3ab3dbc to
d6cb30b
Compare
bosh
force-pushed
the
test_shot_persist_enable
branch
from
d6cb30b to
2821c41
Compare
|
bosh
force-pushed
the
test_shot_persist_enable
branch
from
2821c41 to
0e64c48
Compare
|
bosh
force-pushed
the
test_shot_persist_enable
branch
2 times, most recently
from
3dd7431 to
6349357
Compare
|
…or is currently broken
note that one assertion is commented because it fails and I believe this is a bug. This commit serves to show that the rest of the test passes, and the next commit will fail it.
…lue in configuration
bosh
force-pushed
the
test_shot_persist_enable
branch
from
6349357 to
36bdcba
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the enabled status is persisted whether you like it or not. I have a test case that passes for other property combinations, but not this one. Need to still figure out the root cause/fix