-
Notifications
You must be signed in to change notification settings - Fork 17
Update dependency webpack-dev-middleware to v5 [SECURITY] #5373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -129,7 +129,7 @@ | |
| "webpack": "^4.46.0", | ||
| "webpack-bundle-tracker": "^0.4.3", | ||
| "webpack-cli": "^3.3.10", | ||
| "webpack-dev-middleware": "^1.9.0", | ||
| "webpack-dev-middleware": "^5.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The Suggested FixTo resolve the incompatibility, either upgrade Prompt for AI AgentThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The upgrade of Suggested FixTo resolve this incompatibility, either upgrade Prompt for AI Agent |
||
| "webpack-hot-middleware": "^2.17.1" | ||
| }, | ||
| "engines": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Upgrading
webpack-dev-middlewareto v5 while usingwebpackv4 will cause a runtime error, as v5 requireswebpackv5. This will break the development server.Severity: CRITICAL
Suggested Fix
To resolve this incompatibility, either upgrade
webpackto version 5.0.0 or higher to match thewebpack-dev-middlewarerequirement, or find a version ofwebpack-dev-middlewarethat is compatible withwebpackv4 and also contains the necessary security fix.Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.