-
Notifications
You must be signed in to change notification settings - Fork 110
feat(analytics): Add Swift Package Manager (SPM) support #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheoGermain
wants to merge
5
commits into
mixpanel:main
Choose a base branch
from
TheoGermain:feat/swift-package-manager-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1c45173
feat(ios): add Swift Package Manager (SPM) support
TheoGermain 7c16eb0
Merge branch 'main' into feat/swift-package-manager-support
TheoGermain 1368494
Merge branch 'main' into feat/swift-package-manager-support
TheoGermain bbaa0e1
fix(spm): bump iOS minimum deployment target to 13.0 in Package.swift
TheoGermain fa447ed
Merge branch 'main' into feat/swift-package-manager-support
TheoGermain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 0 additions & 4 deletions
4
packages/mixpanel_flutter/ios/Classes/MixpanelFlutterPlugin.h
This file was deleted.
Oops, something went wrong.
15 changes: 0 additions & 15 deletions
15
packages/mixpanel_flutter/ios/Classes/MixpanelFlutterPlugin.m
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
packages/mixpanel_flutter/ios/Classes/MixpanelTypeHandler.swift
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
packages/mixpanel_flutter/ios/Classes/SwiftMixpanelFlutterPlugin.swift
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
packages/mixpanel_flutter/ios/mixpanel_flutter/Package.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // swift-tools-version: 5.9 | ||
| import PackageDescription | ||
|
|
||
| let package = Package( | ||
| name: "mixpanel_flutter", | ||
| platforms: [ | ||
| .iOS("12.0") | ||
| ], | ||
| products: [ | ||
| .library( | ||
| name: "mixpanel-flutter", | ||
| targets: ["mixpanel_flutter"] | ||
| ) | ||
| ], | ||
| dependencies: [ | ||
| .package( | ||
| url: "https://github.com/mixpanel/mixpanel-swift.git", | ||
| exact: "6.4.0" | ||
| ) | ||
| ], | ||
| targets: [ | ||
| .target( | ||
| name: "mixpanel_flutter", | ||
| dependencies: [ | ||
| .product(name: "Mixpanel", package: "mixpanel-swift") | ||
| ], | ||
| path: "Sources/mixpanel_flutter", | ||
| resources: [] | ||
| ) | ||
| ] | ||
| ) | ||
1 change: 1 addition & 0 deletions
1
.../mixpanel_flutter/ios/mixpanel_flutter/Sources/mixpanel_flutter/MixpanelTypeHandler.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../swift/Classes/MixpanelTypeHandler.swift |
1 change: 1 addition & 0 deletions
1
...el_flutter/ios/mixpanel_flutter/Sources/mixpanel_flutter/SwiftMixpanelFlutterPlugin.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../swift/Classes/SwiftMixpanelFlutterPlugin.swift |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i had recently bumped to iOS 13 in a previous PR. Can we adjust this to 13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, bumped to 13.0 in bbaa0e1. This now matches the podspec and the example Podfile.