feat(analytics): expose serverURL in Mixpanel.init()#245
Open
dt-stokkur wants to merge 1 commit into
Open
Conversation
Adds an optional serverURL named parameter on Mixpanel.init() and forwards it to the native iOS, Android, macOS, and web SDKs at initialization time. Lets callers pin a proxy host or the EU endpoint without making a separate setServerURL call after init.
lifeofnicolas
approved these changes
May 28, 2026
Contributor
|
Hi @lifeofnicolas Thanks for the PR. Will be taking a look. |
tylerjroach
requested changes
Jun 1, 2026
Contributor
tylerjroach
left a comment
tylerjroach
left a comment
There was a problem hiding this comment.
Can you add an explicit null test. Other than that, the PR looks good! Lets get this up to date with the main branch and we can merge this in.
| let superProperties = arguments["superProperties"] as? [String: Any] | ||
| self.token = token | ||
| let trackAutomaticEvents = arguments["trackAutomaticEvents"] as! Bool | ||
| let serverURLArg = arguments["serverURL"] as? String |
Contributor
There was a problem hiding this comment.
let serverURL = (arguments["serverURL"] as? String).flatMap { $0.isEmpty ? nil : $0 }
minor simplification to remove intermediate variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
serverURLnamed parameter onMixpanel.init()and forwards it to the native iOS, Android, macOS, and web SDKs at initialization time. Lets callers pin a proxy host or the EU endpoint without making a separate setServerURL call after init.