Skip to content

server: open authorized_keys files nonblocking #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkj merged 1 commit into from
Apr 17, 2026
+9 −1
Merged

server: open authorized_keys files nonblocking #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/svr-authpubkey.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,10 +503,18 @@ static int checkpubkey(const char* keyalgo, unsigned int keyalgolen,
if (checkpubkeyperms() == DROPBEAR_FAILURE) {
TRACE(("bad authorized_keys permissions, or file doesn't exist"))
} else {
int fd;
/* we don't need to check pw and pw_dir for validity, since
* its been done in checkpubkeyperms. */
filename = authorized_keys_filepath();
authfile = fopen(filename, "r");
fd = open(filename, O_RDONLY | O_NONBLOCK);
if (fd >= 0) {
authfile = fdopen(fd, "r");
if (!authfile) {
/* fdopen could fail with ENOMEM */
m_close(fd);
}
}
if (!authfile) {
TRACE(("checkpubkey: failed opening %s: %s", filename, strerror(errno)))
}
Expand Down