Skip to content

guard mlx_array_dim against 0-dim and out-of-bounds access #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheTom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

guard mlx_array_dim against 0-dim and out-of-bounds access #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mlx/c/array.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,12 @@ extern "C" const size_t* mlx_array_strides(const mlx_array arr) {
}
extern "C" int mlx_array_dim(const mlx_array arr, int dim) {
try {
return mlx_array_get_(arr).shape(dim);
auto& a = mlx_array_get_(arr);
int ndim = a.ndim();
if (ndim == 0) return 1; // scalar: treat as size 1 for any dim
if (dim < 0) dim += ndim;
if (dim < 0 || dim >= ndim) return 0; // out of bounds: return 0 instead of crashing
return a.shape(dim);
} catch (std::exception& e) {
mlx_error(e.what());
return 0;
Expand Down