Fix server XTC: accept int params and flatten special_tokens list#1301
Open
realyxl wants to merge 1 commit into
Open
Fix server XTC: accept int params and flatten special_tokens list#1301realyxl wants to merge 1 commit into
realyxl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mlx_lm.serverrejects integer XTC parameters and crashes wheneverxtc_probability > 0. Two unrelated server-side bugs, both inserver.py.1. Strict
floatrejects integer0/1validate_model_parameters()checksxtc_probability/xtc_thresholdwithfloatalone, while every other sampling parameter in the same block —temperature,top_p,min_p,repetition_penalty,presence_penalty,frequency_penalty— already accepts(float, int). JSON clients (e.g. SillyTavern) that emit0/1as integers get a 4xx.The downstream
apply_xtc/make_samplerhave noisinstancechecks; the values are only used in comparisons and MLX tensor ops, which treatintandfloatidentically.2. Nested
xtc_special_tokenscrashesapply_xtc_make_samplerbuildsxtc_special_tokensas[int, list[int]]becausetokenizer.encode("\n")returns a list. Withxtc_probability > 0,apply_xtcdoesmask[..., xtc_special_tokens] = Falseand raisesValueError: Initialization encountered extra dimension(#1257).generate.py:2070andchat.py:155-157already use the correct flat construction; this alignsserver.pywith them.This also picks up additional EOS tokens on multi-EOS tokenizers (Gemma, Llama 3), which singular
eos_token_idmissed.Related
Fixes #1257.