Add TurboQuant Swift support primitives#412
Closed
RNT56 wants to merge 24 commits into
Closed
Conversation
added 15 commits
May 19, 2026 00:07
added 8 commits
May 19, 2026 00:38
Collaborator
|
Ah wait a sec -- these changes can't go here, they would need to be in mlx itself (Cmlx is mostly a submodule or files built from the submodule when I pick up a new tag). |
Collaborator
|
But: Here is a comment on adding it to mlx: |
Collaborator
|
See also #405 |
Author
|
Thanks, that makes sense. I’ll stop treating #412 as mergeable in this form. I’ll split this up:
I’ll update/close this PR accordingly. |
Author
|
Follow-up: I split the lower-level SwiftPM metallib loader issue into ml-explore/mlx#3562, since that part belongs in MLX rather than this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the lower-level Swift TurboQuant support used by the LM-side KV-cache work:
default.metallibresource for package test/runtime contextsThis is opened as a draft because it is the support branch for the LM-side split and may need to move depending on the preferred boundary with MLX/custom kernels.
Validation
git submodule update --init --recursiveswift test --filter TurboQuantswift test