Skip to content

[FIX] Support IPv6 nameservers in nginx resolver config#3663

Open
muli-cohen wants to merge 1 commit intomlrun:developmentfrom
muli-cohen:fix/ML-12498
Open

[FIX] Support IPv6 nameservers in nginx resolver config#3663
muli-cohen wants to merge 1 commit intomlrun:developmentfrom
muli-cohen:fix/ML-12498

Conversation

@muli-cohen
Copy link
Copy Markdown
Collaborator

@muli-cohen muli-cohen commented Apr 29, 2026

📝 Description

In IPv6 Kubernetes clusters, the mlrun-ui pod fails to start with invalid port in resolver because nginx requires IPv6 addresses to be wrapped in square brackets. The awk command in the Dockerfile CMD writes bare IPv6 addresses (e.g. fd00::10) into /etc/nginx/resolvers.conf, and nginx misinterprets the colons as port separators.


🛠️ Changes Made

  • Updated the awk command in the Dockerfile CMD to detect IPv6 nameservers (containing :) and wrap them in square brackets ([address])
  • IPv4 addresses are unaffected — fully backward-compatible

✅ Checklist

  • I have given the PR a well-structured title describing the domain and the specific change that was made
  • I tested the changes in the browser (locally or via preview build)
  • I confirmed that existing tests pass
  • I checked that this change doesn't introduce new console warnings or lint / formatting errors
  • I updated the relevant Jira ticket with the appropriate details and status

🔗 References


🚨 Potentially Breaking Changes

  • Yes
  • No

Includes DRC change

  • Yes
  • No

🔍 Additional Notes

  • The fix handles all three scenarios: IPv4-only, IPv6-only, and dual-stack clusters
  • Example outputs:
    • IPv4: resolver 10.96.0.10 ;
    • IPv6: resolver [fd00::10] ;
    • Dual-stack: resolver 10.96.0.10 [fd00::10] ;

📸 Screenshots / Demos

N/A - no UI changes; infrastructure/config fix only.


@muli-cohen muli-cohen requested review from amit-noy and yaelgen April 29, 2026 09:21
Copy link
Copy Markdown
Member

@yaelgen yaelgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants