Fix infinite recursion on circular selectable dependencies#469
Open
alex-tan wants to merge 1 commit into
Open
Conversation
get_related_for_item recursed forever when selectables had circular dependent_on/dependents chains (e.g. mutually-referencing views), causing "RangeError: Maximum call stack size exceeded" during load_deps_all. Add a visited set to guard against revisiting the same signature, and filter the root signature out of the result everywhere it reappears (not just the first occurrence via slice(1), which missed later reappearances introduced by the cycle). Includes a regression test that fails with the old recursion (confirmed via RangeError) and passes with this fix.
|
Someone is attempting to deploy a commit to the mmkal Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_related_for_item recursed forever when selectables had circular dependent_on/dependents chains (e.g. mutually-referencing views), causing "RangeError: Maximum call stack size exceeded" during load_deps_all. Add a visited set to guard against revisiting the same signature, and filter the root signature out of the result everywhere it reappears (not just the first occurrence via slice(1), which missed later reappearances introduced by the cycle).
Includes a regression test that fails with the old recursion (confirmed via RangeError) and passes with this fix.