2026 upgrades

.github/workflows/ci.yml

@@ -3,43 +3,24 @@ name: CI
 on: [push, pull_request]
 
 env:
-  NODE_VERSION: '16'
+  NODE_VERSION: '24.13.0'
 
 jobs:
   lint:
     name: Lint
     runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          fetch-depth: 1
 
-      - uses: actions/setup-node@v2-beta
+    steps:
+      - uses: actions/checkout@v4
+      - name: Install Node
+        uses: actions/setup-node@v4
         with:
           node-version: '${{ env.NODE_VERSION }}'
-
-      - name: Get Yarn cache path
-        id: global-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn cache dir)"
-
-      - name: Cache Yarn cache and node_modules
-        id: cache-dependencies
-        uses: actions/cache@v2
-        with:
-          path: |
-            ${{ steps.global-cache-dir-path.outputs.dir }}
-            node_modules
-          key: ${{ runner.os }}-${{ matrix.node-version }}-${{
-            hashFiles('**/yarn.lock'
-            ) }}
-          restore-keys: |
-            ${{ runner.os }}-${{ matrix.node-version }}-
-
+          cache: yarn
+      - name: Enable Corepack
+        run: corepack enable
       - name: Install Dependencies
-        run: yarn install --frozen-lockfile
-        if: |
-          steps.cache-dependencies.outputs.cache-hit != 'true'
-
+        run: yarn install --immutable
       - name: Lint
         run: yarn lint
 
@@ -50,30 +31,19 @@ jobs:
 
     steps:
       - name: Check out a copy of the repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Use Node.js ${{ env.NODE_VERSION }}
-        uses: actions/setup-node@v2-beta
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ env.NODE_VERSION }}
+          cache: yarn
 
-      - name: Get Yarn cache path
-        id: yarn-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn cache dir)"
-
-      - name: Cache Yarn cache and node_modules
-        id: cache-dependencies
-        uses: actions/cache@v2
-        with:
-          path: |
-            ${{ steps.yarn-cache-dir-path.outputs.dir }}
-            node_modules
-          key: ${{ runner.os }}-${{ env.NODE_VERSION }}-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: ${{ runner.os }}-${{ env.NODE_VERSION }}-
+      - name: Enable Corepack
+        run: corepack enable
 
       - name: Install dependencies
-        run: yarn install --frozen-lockfile
-        if: steps.cache-dependencies.outputs.cache-hit != 'true'
+        run: yarn install --immutable
 
       - name: Test
         run: yarn test:ember
@@ -85,34 +55,23 @@ jobs:
 
     steps:
       - name: Check out a copy of the repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Use Node.js ${{ env.NODE_VERSION }}
-        uses: actions/setup-node@v2-beta
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ env.NODE_VERSION }}
+          cache: yarn
 
-      - name: Get Yarn cache path
-        id: yarn-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn cache dir)"
-
-      - name: Cache Yarn cache and node_modules
-        id: cache-dependencies
-        uses: actions/cache@v2
-        with:
-          path: |
-            ${{ steps.yarn-cache-dir-path.outputs.dir }}
-            node_modules
-          key: ${{ runner.os }}-${{ env.NODE_VERSION }}-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: ${{ runner.os }}-${{ env.NODE_VERSION }}-
+      - name: Enable Corepack
+        run: corepack enable
 
       - name: Install dependencies
-        run: yarn install --frozen-lockfile
-        if: steps.cache-dependencies.outputs.cache-hit != 'true'
+        run: yarn install --immutable
 
       - name: Cache litmus
         id: cache-litmus
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/litmus
           key: ${{ runner.os }}-litmus
@@ -139,4 +98,4 @@ jobs:
 
       - name: Test server
         if: always()
-        run: yarn test-server
+        run: yarn test:server

.github/workflows/spk-build-reusable.yml

@@ -100,9 +100,9 @@ jobs:
           set -euo pipefail
           mkdir -p build
           if [ "${{ inputs.pack_mode }}" = "test" ]; then
-            pack_log="$(mktemp)"
-            lima-spk pack --dev --set-version "${GITHUB_SHA}" "${{ inputs.spk_output_path }}" 2>&1 | tee "$pack_log"
-            package_id="$(grep -Eo '[a-z0-9]{52,64}' "$pack_log" | tail -n1 || true)"
+            pack_json="$(lima-spk pack --dev --set-version "${GITHUB_SHA}" "${{ inputs.spk_output_path }}")"
+            printf '%s\n' "$pack_json"
+            package_id="$(printf '%s\n' "$pack_json" | jq -r '.packageId // empty')"
             if [ -n "$package_id" ]; then
               echo "package_id=$package_id" >> "$GITHUB_OUTPUT"
             fi
@@ -258,7 +258,7 @@ jobs:
               issue_number,
               per_page: 100,
             });
-            const existing = comments.find((comment) => comment.user.type === "Bot" && comment.body.includes(marker));
+            const existing = comments.find((comment) => comment.body.includes(marker));
 
             if (existing) {
               await github.rest.issues.updateComment({

.github/workflows/spk.yml

@@ -17,6 +17,7 @@ on:
 
 permissions:
   contents: write
+  issues: write
   pull-requests: write
 
 jobs:

.gitignore

@@ -22,7 +22,9 @@ npm-debug.log*
 yarn-error.log
 testem.log
 /.cache-require-paths.json
-/.yarn
+/.yarn/*
+!/.yarn/releases/
+!/.yarn/releases/*
 
 # webdav data
 /data/*
@@ -32,4 +34,7 @@ testem.log
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try

.prettierignore

@@ -14,8 +14,12 @@
 /coverage/
 !.*
 .eslintcache
+.lint-todo/
 
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try

.sandstorm/Vagrantfile

@@ -19,8 +19,8 @@ unless Vagrant::DEFAULT_SERVER_URL.frozen?
 end
 
 Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
-  # Base on the Sandstorm snapshots of the official Debian 9 (stretch) box with vboxsf support.
-  config.vm.box = "debian/contrib-stretch64"
+  # Based on Debian 12
+  config.vm.box = "debian/contrib-bookworm64"
   config.vm.post_up_message = "Your virtual server is running at http://local.sandstorm.io:6090."
 
 

.sandstorm/build.sh

@@ -1,15 +1,43 @@
 #!/bin/bash
 
+set -euo pipefail
+
+export HOME="${HOME:-/home/vagrant}"
+
 cd /opt/app
 
-# ensure data storage directory exists
 sudo mkdir -p /var/davros
-sudo chown $USER /var/davros
+sudo chown "$USER" /var/davros
 mkdir -p /var/davros/data
 
+lock_hash_file="/opt/app/node_modules/.yarn-lock.sha256"
+if command -v sha256sum >/dev/null 2>&1; then
+  current_lock_hash="$(sha256sum /opt/app/yarn.lock | awk '{print $1}')"
+else
+  current_lock_hash="$(shasum -a 256 /opt/app/yarn.lock | awk '{print $1}')"
+fi
+
+need_install=0
 if [ ! -d "/opt/app/node_modules" ]; then
-    yarn install
+  need_install=1
+elif [ ! -f "$lock_hash_file" ]; then
+  need_install=1
+elif [ "$(cat "$lock_hash_file")" != "$current_lock_hash" ]; then
+  need_install=1
 fi
+
+if [ "$need_install" -eq 1 ]; then
+  export CC=clang
+  export CXX=clang++
+  export npm_config_cxxflags="-std=gnu++20"
+  export CXXFLAGS="-std=gnu++20"
+  yarn install
+  mkdir -p /opt/app/node_modules
+  printf '%s\n' "$current_lock_hash" > "$lock_hash_file"
+fi
+
 if [ ! -d "/opt/app/dist" ]; then
-    ./node_modules/.bin/ember build
+  ./node_modules/.bin/ember build
 fi
+
+yarn build:server

.sandstorm/compile_helper.sh

@@ -1,25 +1,15 @@
-### Download & compile capnproto and the Sandstorm getPublicId helper.
+### Install capnproto and build the Sandstorm getPublicId helper.
 
-# First, get capnproto from master and install it to
-# /usr/local/bin. This requires a C++ compiler. We opt for clang
-# because that's what Sandstorm is typically compiled with.
-if [ ! -e /usr/local/bin/capnp ] ; then
-    sudo DEBIAN_FRONTEND=noninteractive apt-get install -y -q clang autoconf pkg-config libtool
-    cd /tmp
-    if [ ! -e capnproto ]; then git clone https://github.com/capnproto/capnproto; fi
-    cd capnproto
-    git checkout master
-    cd c++
-    autoreconf -i
-    ./configure
-    make -j2
-    sudo make install
+# First, install capnp from apt along with headers/libs used by
+# sandstorm-integration/Makefile.
+if ! command -v capnp >/dev/null 2>&1 || ! pkg-config --exists capnp-rpc ; then
+    sudo DEBIAN_FRONTEND=noninteractive apt-get install -y -q clang-19 clang++-19 make pkg-config capnproto libcapnp-dev
 fi
 
 # Second, compile the small C++ program within
 # /opt/app/sandstorm-integration.
 if [ ! -e /opt/app/sandstorm-integration/getPublicId ] ; then
     pushd /opt/app/sandstorm-integration
-    make
+    make CXX=clang++-19
 fi
 ### All done.