Skip to content

flush pingora stream immediately #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
molocule wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

flush pingora stream immediately #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pingora-core/src/protocols/http/v1/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,6 +1159,12 @@ impl HttpSession {
}
HttpTask::UpgradedBody(data, end_stream) => {
self.write_non_empty_body(data, true).await?;
if !end_stream {
self.underlying_stream
.flush()
.await
.or_err(WriteError, "flushing upgraded body")?;
}
end_stream
}
HttpTask::Trailer(_) => true, // h1 trailer is not supported yet
Expand Down Expand Up @@ -1231,6 +1237,11 @@ impl HttpSession {
if end_stream {
// no-op if body wasn't initialized or is finished already
self.finish_body().await.map_err(|e| e.into_down())?;
} else if self.upgraded {
self.underlying_stream
.flush()
.await
.or_err(WriteError, "flushing upgraded body")?;
}
Ok(end_stream || self.body_writer.finished())
}
Expand Down
Loading